New MythTV add-on using libcmyth

tsp42 · 2012-04-25 19:04

Hmm tested LiveTV again on my linux box. It shows the same error as has previous been posted. Very strange that the windows version isn't affected. Will see if I can find a solution.

bilbonvidia · 2012-04-25 20:33

Thank you very much, it is appreciated! :-)

Jimmer · 2012-04-25 21:11

(2012-04-25 20:33)bilbonvidia Wrote: Thank you very much, it is appreciated! :-)

Hey man, I think I've sussed out how to go back to a previous commit from the commandline:

first, run the following from the xbmc source directory:

Code:

git log --pretty=oneline

this will produce a list of commits with their sha, eg:

Code:

78390d6026d0fd367e83f7c98fc8fc0ea33dcd77 FIX: missing else in CPVRClients::GetStreamPosition(). Thanks to dodoadoodoo for noticing it.

7f687366c3abf83541f881801a3839387abd98d9 ADDED: Check program id to see if a recording is a movie

68e2f7fe7b7b02ba62b074d317d873c09231550b ADDED: Initial support for working timeshift.

5d0473ef81d516992eba9eb41d62d1c8fb069e57 FIX: fileOps check if directory exist before cleaning it FIX: use fopen instead of std::fstream as the later is incompatible with emufilewrapper in win32 for some

69b160b78ab9ed50d670ab5db450b93ce8dd01c5 FIX: missing source files and updated Makefile

7e9bad8b08ca5ee4a3d3321d99740bb260a9d4b8 FIX: error in addon.xml

9a98a90486378cdcb17bd1ae40f88e83c484d127 Merge remote-tracking branch 'upstream/master'

1e0bf4d93ba139c3bc12bb222159a60b9865cb6f ADDED: Changed default regex for folder naming to use subtitle separator. Now possible to change the title. ADDED: Optional regex to detect series. MAJOR FIX: lib

939413a1aa14357f0c794113abb2912422619181 FIX: rewrote the artwork code. Will now use preview image if no fanart is present.

7bc746d1da54aaa83da026eb45566c2e81309153 Merge branch 'PR488'. closes #488

bd71a3d76a4b11477629eb8761446f79764c2aef epg: new channel context menu item in channel groups that allows updating of EPG information for specific channel on demand

53d808a4c5ce8bce8585e00bcd4f0eeb0793892a Merge branch 'PR501'. closes #501

6a0aae1ebf69a27a21e74b173de5a916a1fcd76c Set folder date to the date of the most recent recording it contain.

5a04feeec234950e70adc1b48ab5f30038e2a16a Merge branch 'PR506'. closes #506

278512022a590a7f7b2fc0567c0b777361d364c2 pvr: fixed deadlock on creating thumbnails

6e396746d84fd3c6e100d6e4fb5990f487fbef0d pvr: fix recording path for subdirectories

db7f030a3eaaefc5b11fbc09ec2daba9c384aab3 Merge remote branch 'upstream-ro/master'

b95739e4fada671e2effaf180748492dae3edebf jsonrpc: fix sorting in Files.GetSources (fixes #12932)

03c298e013b83e0fbadec89e7df37fd37a436c52 Merge pull request #809 from scarabeusiv/ffmpeg10

snip.....

then you decide what commit you want to go back to, e.g I like the look of:

Code:

1e0bf4d93ba139c3bc12bb222159a60b9865cb6f ADDED: Changed default regex for folder naming to use subtitle separator. Now possible to change the title. ADDED: Optional regex to detect series. MAJOR FIX: lib

Take the first 8 digits of the number displayed by the commit you want (in this example 1e0bf4d9) and type the following:

Code:

git reset --hard 1e0bf4d9

this will reset the repo to this commit (I think!)

if you want to go back to the current commit, then a simple:

Code:

git pull

should do the trick. I should mention that I forked tsp's branch to test and play around with git, so I'm new to all this and this may not be correct. It also assumes that you know the commit that you wish to go back to. That may require some trail and error on your part......

Anyway, it's something that I've long wondered about, so you prompted me to check it out. If I've done it wrong, someone please chip in!

PS what platform are you compiling on? If it's a debian based linux, I can let you have the checkinstall commandline I use to produce a deb on install if you'd like? Makes switching between compiles as easy as using dpkg -r and then dpkg -i......

InoD · 2012-04-25 22:03

(2012-04-23 21:36)InoD Wrote: Great update!

Unfortunately suspend stopped working for me (nothing happens), so switched back to my previous build while building latest OpenELEC in the meantime.
It does seem my issue with myth:// protocol is still there. Could you look into that tsp? Thanks!

I've tried to investigate the problem a bit myself, but it seems that it is unrelated to the myth:// protocol.
Somehow, the logs I posted didn't have the following three lines:

Code:

46:43 T:139913124009792   ERROR: CWinSystemX11::XErrorHandler: BadDrawable (invalid Pixmap or Window parameter), type:0, serial:49, error_code:9, request_code:136 minor_code:12

46:43 T:139913124009792   ERROR: CWinSystemX11::XErrorHandler: BadDrawable (invalid Pixmap or Window parameter), type:0, serial:50, error_code:9, request_code:136 minor_code:12

46:43 T:139913124009792   ERROR: CWinSystemX11::XErrorHandler: BadDrawable (invalid Pixmap or Window parameter), type:0, serial:51, error_code:9, request_code:136 minor_code:12

When I google for these errors, it seems we're not the only ones with this problem and no real solution yet. I will see if I can create a debug build of OpenELEC (could do with standalone debug build of XBMC, but something tells me it is hardware related as well).

bilbonvidia · 2012-04-25 22:24

@Jimmer Thanks mate, I had been trying to figure it out, you beat me to it.

tsp42 · 2012-04-25 22:45

I disabled time shift on Linux in the latest update so it should be usable till I find the obscure bug (fearing that it is ffmpeg again. Stupid decoder. Suspect that dteirney can agree on that).

Jimmer · 2012-04-26 00:20

(2012-04-25 22:45)tsp42 Wrote: I disabled time shift on Linux in the latest update so it should be usable till I find the obscure bug (fearing that it is ffmpeg again. Stupid decoder. Suspect that dteirney can agree on that).

just tried to compile on linux:

Code:

CPP     xbmc/pvr/addons/PVRClients.o

PVRClients.cpp:360:6: error: #elif with no expression

PVRClients.cpp: In member function ‘int64_t PVR::CPVRClients::SeekStream(int64_t, int)’:

PVRClients.cpp:364:3: error: ‘else’ without a previous ‘if’

seems the changes to PVRClients.cpp are not so robust! I just re-edited PVRClients to revert the changes and compiling proceeds on successfully.....

.... plus was still wondering what part of mythconverg the addon references to download the artwork. Still trying to track that problem down! The only reference to art storage groups references /var/lib/mythtv ..... whereas my storage groups are on my server and mounted on my backend at /media/PVR/...... I can't find an entry that may contain filelists or anything like that. Any help would be appreciated!

tsp42 · 2012-04-26 00:44

Fixed. I also found the reason why LiveTV wasn't working on Linux. Turned out that the mutex used on Linux in libcmyth is not reentrant so liveTV seeking caused the thread to deadlock. The mutex on windows is reentrant so no deadlock occurred.

cfetzer · 2012-04-26 08:48

Nice work! Smile

Just one small thing: Either the onleft/onright or the order of rewind and pause is swapped. If you're on rewind and press right on the remote then you land on pause. (in both, home and osd)

Short update on the 'Mark recordings as watched': (https://github.com/opdenkamp/xbmc/pull/508) PR is still open as I had to fix a few smaller issues. I added now also the watched overlay for folders allowing you to easily find out if you have unwatched episodes. :-) Hope it gets merged soon.

chrisgibbs · 2012-04-26 08:57

(2012-04-26 00:44)tsp42 Wrote: Fixed. I also found the reason why LiveTV wasn't working on Linux. Turned out that the mutex used on Linux in libcmyth is not reentrant so liveTV seeking caused the thread to deadlock. The mutex on windows is reentrant so no deadlock occurred.

Great work. I can confirm this has also resolved my issue.

Thanks for the commit.

tsp42 Senior Member Posts: 222 Joined: Aug 2011 Reputation: 11 Location: Denmark	2012-04-25 19:04 Post: #681 Hmm tested LiveTV again on my linux box. It shows the same error as has previous been posted. Very strange that the windows version isn't affected. Will see if I can find a solution. Libcmyth MythTV addon for xbmc-pvr [source] [forum thread]
	find quote

bilbonvidia Fan Posts: 436 Joined: Jun 2011 Reputation: 2 Location: Britain	2012-04-25 20:33 Post: #682 Thank you very much, it is appreciated! :-)
	find quote

bilbonvidia Fan Posts: 436 Joined: Jun 2011 Reputation: 2 Location: Britain	2012-04-25 22:24 Post: #685 @Jimmer Thanks mate, I had been trying to figure it out, you beat me to it.
	find quote

tsp42 Senior Member Posts: 222 Joined: Aug 2011 Reputation: 11 Location: Denmark	2012-04-25 22:45 Post: #686 I disabled time shift on Linux in the latest update so it should be usable till I find the obscure bug (fearing that it is ffmpeg again. Stupid decoder. Suspect that dteirney can agree on that). Libcmyth MythTV addon for xbmc-pvr [source] [forum thread]
	find quote

tsp42 Senior Member Posts: 222 Joined: Aug 2011 Reputation: 11 Location: Denmark	2012-04-26 00:44 Post: #688 Fixed. I also found the reason why LiveTV wasn't working on Linux. Turned out that the mutex used on Linux in libcmyth is not reentrant so liveTV seeking caused the thread to deadlock. The mutex on windows is reentrant so no deadlock occurred. Libcmyth MythTV addon for xbmc-pvr [source] [forum thread] (This post was last modified: 2012-04-26 00:44 by tsp42.)
	find quote