Posts: 1,292
Joined: Sep 2009
Reputation:
71
I don't know the exact PR on github that merged this request in or I'd just try and sift through the code myself. I read on the XBMC Blog that a new Gotham feature is that library items are not removed when doing a clean and your media server is temporarily offline.
My guess is that the clean operation checks if you've actually removed a source from sources.xml, and then tests that the root directory of that source is accessible before determining if any files it contains are removed or not. Is this pretty close to how it functions?
My reason for asking is that the Library Update addon I maintain currently has a setting to "verify paths" before issueing the CleanLibrary() command that the user can setup via a timer. This was to eliminate the temporarily offline behavior. If the Clean function will now do this sort of thing I can remove this check for the Gotham version of the addon.
Thanks!
Posts: 5,184
Joined: Jan 2009
Reputation:
131
I added the logic. XBMC remembers the parent path (path of the source) for every file. With the new behaviour, whenever it finds a file that doesn't exists anymore it checks if the parent path still exists. If it does, it assumes that the file was deleted intentionally. If the parent path is missing as well it lets the user choose whether to remove all items from that source or to keep them all).
Always read the
online manual (wiki),
FAQ (wiki) and search the forum before posting.
Do not e-mail Team Kodi members directly asking for support. Read/follow the
forum rules (wiki).
Please read the pages on
troubleshooting (wiki) and
bug reporting (wiki) before reporting issues.
Posts: 1,292
Joined: Sep 2009
Reputation:
71
Awesome. Thanks for the clarification. I'll add removing this to my list of Gotham changes. No need to verify sources independently if this logic is in place within the CleanLibrary() functionality.
Posts: 17,859
Joined: Jul 2011
Reputation:
371
I have extra levels
Movies
---Animation
------Movie1
------Movie2
----General
------Movie3
Source is on Movies. So far i haven't experienced this although my source is rarely offline
Posts: 5,184
Joined: Jan 2009
Reputation:
131
From the problem description I guess it only happens when you would e.g. move "Animation" out of "Movies" or rename it to something else.
Always read the
online manual (wiki),
FAQ (wiki) and search the forum before posting.
Do not e-mail Team Kodi members directly asking for support. Read/follow the
forum rules (wiki).
Please read the pages on
troubleshooting (wiki) and
bug reporting (wiki) before reporting issues.
Posts: 82
Joined: Oct 2013
Reputation:
0
2014-05-15, 09:34
(This post was last modified: 2014-05-15, 09:43 by Bazzu85.)
I propose..
Why don't you add a sub options of "Clean library" to let choose user what to do with these media?
"Auto delete" (like in Frodo) or "Ask" (like now)?
Another thing is that when you have to choose to delete or keep media..you can't abort library clean..if I press esc key he continue with next media..
Posts: 82
Joined: Oct 2013
Reputation:
0
with tv show I've no problems because the structure is for example:
Anime (source) - Ranma 1/2 -> Season 01
if I rename Ranma 1/2 to Ranma the cleanup is automatic..
Posts: 82
Joined: Oct 2013
Reputation:
0
Can you give me a feedback?
Do you plan to resolve this "problem"?
Posts: 5,184
Joined: Jan 2009
Reputation:
131
You'll have to be a bit more patient.
My time to work on xbmc is limited and this is not at the top of the list.
Always read the
online manual (wiki),
FAQ (wiki) and search the forum before posting.
Do not e-mail Team Kodi members directly asking for support. Read/follow the
forum rules (wiki).
Please read the pages on
troubleshooting (wiki) and
bug reporting (wiki) before reporting issues.
Posts: 82
Joined: Oct 2013
Reputation:
0
Ok..
Let me know when you think to face the problem..