[realcopacetic]

Hi, I've been learning Python and using it to make a helper addon for my skin. I took @sualfred's Embuary helper addon as my starting point. Although I removed a lot of the code and changed  most of the functions, the 2 widget plugins I kept are the same in logic and in code, apart from some updates I made to ensure it's in line with Nexus requirements.

So my question is... what is the correct way to attribute Sualfred's work in my addon? Do I put something in the code itself, or in the addon description? Should I fork his code then overwrite it with my own code so there's a clear trail? What's the best practice here?

[basilgello]

In copyright header of every file in your addon you put your copyright in the bottom (chronologically) and retain previous authors copyrights on top.

Look at https://archive.fosdem.org/2021/schedule...Slides.pdf
and https://github.com/HowardHinnant/date/bl...src/tz.cpp

In Debian, there is debian/copyright file for this purpose, and it serves several sidetrack purposes in Debian packaging.
For a simple addon, the copyright file looks like: https://salsa.debian.org/multimedia-team.../copyright

For Python and Shell ways to provide copyright info, look at https://github.com/peterjc/thapbi-pict/c...4290e88a5c

In VCS commits, like Git, the proper way to attribute others' work is to cherry-pick or apply patches using git am. The author and date of the original commit should not be stripped or changed. However, if you add changes to the commit body (like porting the commit to older version of software), you add a comment describing what and why you changed followed by "Signed-off-By:" statement (you can request Git to include it in commit mesage by giving "--signoff" argument to "git commit"): https://github.com/LineageOS/android_ker...06fad09f73

[realcopacetic]

In copyright header of every file in your addon you put your copyright in the bottom (chronologically) and retain previous authors copyrights on top.

Look at https://archive.fosdem.org/2021/schedule...Slides.pdf
and https://github.com/HowardHinnant/date/bl...src/tz.cpp

In Debian, there is debian/copyright file for this purpose, and it serves several sidetrack purposes in Debian packaging.
For a simple addon, the copyright file looks like: https://salsa.debian.org/multimedia-team.../copyright

For Python and Shell ways to provide copyright info, look at https://github.com/peterjc/thapbi-pict/c...4290e88a5c

In VCS commits, like Git, the proper way to attribute others' work is to cherry-pick or apply patches using git am. The author and date of the original commit should not be stripped or changed. However, if you add changes to the commit body (like porting the commit to older version of software), you add a comment describing what and why you changed followed by "Signed-off-By:" statement (you can request Git to include it in commit mesage by giving "--signoff" argument to "git commit"): https://github.com/LineageOS/android_ker...06fad09f73

Thanks for this!