verify rev 18873 is permanent

  Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
Nuka1195 Offline
Skilled Python Coder
Posts: 3,910
Joined: Dec 2004
Reputation: 18
Post: #1
Quote:
fixed: Ticket #5082 - TinyXML's SetCondenseWhitespace was used inconsistently across XBMC (and wasn't threadsafe). It is now defaulted to false, and we don't touch it.

before i change all my xml files, just want to make sure the change will be permanent.

this use to print on consecutive lines, now it skips a line. so i need to remove all & # 10 ; .
PHP Code:
<label>line of text # 10 ;
       
line 2 of text</label

For python coding questions first see http://mirrors.xbmc.org/docs/python-docs/
find quote
Nuka1195 Offline
Skilled Python Coder
Posts: 3,910
Joined: Dec 2004
Reputation: 18
Post: #2
this also affects visibility tags

i did this for readability
this use to work, now i have to have it on one line.
PHP Code:
<visible>[StringCompare(Window.Property(CurrentView),200) + IsEmpty(Window.Property(36Hour3title)) ] | 
                          [
StringCompare(Window.Property(CurrentView),202) + IsEmpty(Window.Property(HBHHead1)) ] | 
                          [
StringCompare(Window.Property(CurrentView),203) + IsEmpty(Window.Property(Weekend3day)) ] | 
                          [
StringCompare(Window.Property(CurrentView),204) + IsEmpty(Window.Property(10DayHead1)) ]
            </
visible

For python coding questions first see http://mirrors.xbmc.org/docs/python-docs/
find quote
spiff Offline
Retired Developer
Posts: 12,386
Joined: Nov 2003
Post: #3
this is permanent. painful for a while but worth it in the end. it will make .nfo files easier to do for instance.
find quote
jmarshall Offline
Team-XBMC Developer
Posts: 26,228
Joined: Oct 2003
Reputation: 177
Post: #4
The visibility stuff shouldn't be a problem though I would think? I can easily make it ignore whitespace between operators if it doesn't work as-is.

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


[Image: badge.gif]
find quote
Nuka1195 Offline
Skilled Python Coder
Posts: 3,910
Joined: Dec 2004
Reputation: 18
Post: #5
it wasn't working here until i put it all on one line. not a big deal. i only did it for readability.

what about an option in the visible tag?

<visible orred="true">

For python coding questions first see http://mirrors.xbmc.org/docs/python-docs/
find quote
jmarshall Offline
Team-XBMC Developer
Posts: 26,228
Joined: Oct 2003
Reputation: 177
Post: #6
Nah - better just to allow the linebreaks in there - will look into it.

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


[Image: badge.gif]
find quote
jmarshall Offline
Team-XBMC Developer
Posts: 26,228
Joined: Oct 2003
Reputation: 177
Post: #7
Try altering this (ln 157, GUIInfoManager.cpp):

Code:
strTest.TrimLeft(" ");
  strTest.TrimRight(" ");

to this:

Code:
strTest.TrimLeft(" \t\r\n");
  strTest.TrimRight(" \t\r\n");

and see if that does the trick.

Cheers,
Jonathan

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


[Image: badge.gif]
find quote