Music codec flagging support for Confluence

**alanwww1** · 2009-12-03 21:33

Hello Jezz !

I reworked all the things according to the advices came from you.

Now only in Visulalization Mode we have flags on the info window, under the rating stars,
with the same icon for mp3 we have for the videoflagging.

Check screenshots:

I hope this time you like it.

If so i really hope this goes into Camelot final :-)

The package is in the updated FIRST POST.
http://forum.xbmc.org/attachment.php?att...1259876982

Here is the diff:

http://pastebin.com/f9cea85f

**alanwww1** · 2009-12-04 22:07

Hello Jezz !

Can you give me some feedback if you liked the reworked Musicflagging. I think now it is really worth a check.

Thanks,

Alan

**Jezz_X** · 2009-12-05 04:58

holy crap I never realized so many codecs Smile

Its better yes but its still not high on the list of thinsg to add. I will add it one day soon I promise

Nuka1195 · 2009-12-05 05:39

looking at your diff. at least for music flagging the substring always matches the filename (maybe video flagging also) do this with one control.

something like

PHP Code:

<control type="image">
  <width>86</width>
  <aspectratio>keep</aspectratio>
  <texture>$INFO[musicplayer.codec,flagging/audio/music/,.png]</texture>
  <visible>!IsEmpty(musicplayer.codec)</visible>
</control> 

**Jezz_X** · 2009-12-05 06:47

indeed since he pretty much has every codec image

**alanwww1** · 2009-12-05 09:21

Jezz_X Wrote:indeed since he pretty much has every codec image

Thanks for the feedback guys.

I tried to make it the with one line, but it caused me some problems on Linux systems with capital and not capital characters, Also this way we would need to have more image files for the various alterations.

If you could help me where i can find in the code ALL possible codec's spelling i can make it with one line.

For example flac is spelled with capped letters FLAC
Wavepack is spelled like this "WAVPack"

You see it is not obvious in many cases.

I thought it would be a nice thing to add in the stable release Nod

No chance for that at all ?

Jezz_X Team-XBMC Skinner Posts: 5,263 Joined: Jun 2006 Reputation: 55 Location: Earth	2009-12-05 04:58 Post: #13 holy crap I never realized so many codecs Its better yes but its still not high on the list of thinsg to add. I will add it one day soon I promise Skins I have done.... And others in the past... Want to know what I'm working on currently? Check me out on Google+
	find quote

Jezz_X Team-XBMC Skinner Posts: 5,263 Joined: Jun 2006 Reputation: 55 Location: Earth	2009-12-05 06:47 Post: #15 indeed since he pretty much has every codec image Skins I have done.... And others in the past... Want to know what I'm working on currently? Check me out on Google+
	find quote