some default icons treated as thumbs

Arcanthur · 2010-07-28 18:42

I was working on my default icons and came across the same issue this trac ticket refers to, just wondering if it has been looked into yet as I don't see anything on the ticket:

http://trac.xbmc.org/ticket/7351

**jmarshall** · 2010-07-29 00:10

Will look into it in a bit.

**jmarshall** · 2010-07-29 02:30

r32269 (trunk - will be merged to Dharma this evening) fixes the "add source" one. Are there any others that are outstanding?

Cheers,
Jonathan

Hitcher · 2010-07-29 07:38

Not so much a skinning problem but the 'No thumb' option doesn't clear the currently selected thumb.

**jmarshall** · 2010-07-29 07:49

Where? There's all sorts of places that "No thumb" might work and might not, so specifics will be needed.

Cheers,
Jonathan

Hitcher · 2010-07-29 16:39

Sorry, for me it was in Videos.

One of my source folders had a folder.jpg from an album in it once so XBMC set that as the thumb and trying to remove it by selecting 'Choose thumbnail' and then 'No thumb' doesn't clear it.

Arcanthur · 2010-07-29 21:24

jmarshall Wrote:r32269 (trunk - will be merged to Dharma this evening) fixes the "add source" one. Are there any others that are outstanding?

Cheers,
Jonathan

Thanks Johnathan, I'm looking through now and it looks like only add source and "available updates" and "enable addons" needed fixing, so now just the two in the addon browser. Smile

**jmarshall** · 2010-07-30 02:04

@Hitcher, so a video source with folder.jpg present?

@Arcanthur - cheers, will take a look.

**jmarshall** · 2010-07-30 02:41

@Arcanthur: those ones are taken care of - there are better ways to do it, though but the fix in r32328 will do for now.

@Hitcher: Yeah, "no thumb" won't work there as the folder.jpg image will just go and be cached again later. There's no easy way to deal with this situation unfortunately. Two options:

1. Remove the "No thumb" option if a local thumb is present.
2. Remove the use of folder.jpg etc. for shares.

I think I prefer 1.

Cheers,
Jonathan

Hitcher · 2010-07-30 07:34

It wasn't there for long but now it's removed the thumb is the same.

Arcanthur Skilled Skinner Posts: 368 Joined: Sep 2008 Reputation: 4 Location: 33.65 84.42	2010-07-28 18:42 Post: #1 I was working on my default icons and came across the same issue this trac ticket refers to, just wondering if it has been looked into yet as I don't see anything on the ticket: http://trac.xbmc.org/ticket/7351
	find quote

jmarshall Team-XBMC Developer Posts: 24,523 Joined: Oct 2003 Reputation: 138	2010-07-29 00:10 Post: #2 Will look into it in a bit. Always read the XBMC online-manual, FAQ and search the forum before posting. Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules. For troubleshooting and bug reporting please make sure you read this first.
	find quote

Hitcher Skilled Skinner Posts: 9,927 Joined: Aug 2007 Reputation: 67 Location: Eastleigh, UK	2010-07-29 07:38 Post: #4 Not so much a skinning problem but the 'No thumb' option doesn't clear the currently selected thumb.
	find quote

Hitcher Skilled Skinner Posts: 9,927 Joined: Aug 2007 Reputation: 67 Location: Eastleigh, UK	2010-07-29 16:39 Post: #6 Sorry, for me it was in Videos. One of my source folders had a folder.jpg from an album in it once so XBMC set that as the thumb and trying to remove it by selecting 'Choose thumbnail' and then 'No thumb' doesn't clear it.
	find quote

Arcanthur Skilled Skinner Posts: 368 Joined: Sep 2008 Reputation: 4 Location: 33.65 84.42	2010-07-29 21:24 Post: #7 jmarshall Wrote:r32269 (trunk - will be merged to Dharma this evening) fixes the "add source" one. Are there any others that are outstanding? Cheers, Jonathan Thanks Johnathan, I'm looking through now and it looks like only add source and "available updates" and "enable addons" needed fixing, so now just the two in the addon browser.
	find quote

jmarshall Team-XBMC Developer Posts: 24,523 Joined: Oct 2003 Reputation: 138	2010-07-30 02:04 Post: #8 @Hitcher, so a video source with folder.jpg present? @Arcanthur - cheers, will take a look. Always read the XBMC online-manual, FAQ and search the forum before posting. Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules. For troubleshooting and bug reporting please make sure you read this first.
	find quote

Hitcher Skilled Skinner Posts: 9,927 Joined: Aug 2007 Reputation: 67 Location: Eastleigh, UK	2010-07-30 07:34 Post: #10 It wasn't there for long but now it's removed the thumb is the same.
	find quote