High Res 4:3

  Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
dazex Offline
Member+
Posts: 548
Joined: Nov 2009
Reputation: 0
Post: #11
I wasn't able to get the arbitrary res working. Not certain what to add to my addons.xml.

I had the same dilemma as you. I decided to create a very simple, native skin first. Blending apple's native ui with just the right amount of xbmc's flair. Then do a more "original" skin to taste should I have the time and desire.

But what irks me right now is the aspect ratio, making the interface images stretch on 4:3 devices like the iPad. For minimal GUI designs such as Apple with their iPad, pixel perfect makes a big difference. Thus why I wentlooking for ways to enabled this.

I think i got jmarshal's code merge to main branch. But I need to see if my manual patching of the files actually worked. With some quick instructions from you or jmarshall on how to enable high res 4:3 detection, I think I can resume skinning.

Thanks.
(This post was last modified: 2011-04-14 16:03 by dazex.)
find quote
jmarshall Offline
Team-XBMC Developer
Posts: 24,523
Joined: Oct 2003
Reputation: 138
Post: #12
Jezz_X would be the best one to ask about the xml - it's been too long since I worked on it.

What I want to do is the "centering" type thing where you can specify that a group should keep aspect (i.e. scale in only one direction). Placement is a little bit of an issue though (eg a group in the middle of the screen should be anchored in the middle, rather than at the left edge).

Cheers,
Jonathan

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


[Image: badge.gif]
find quote
Jezz_X Offline
Team-XBMC Skinner
Posts: 5,264
Joined: Jun 2006
Reputation: 55
Location: Earth
Post: #13
Addon.xml goes like this
PHP Code:
<?xml version="1.0" encoding="UTF-8"?>
<addon
  id="skin.TestTouchscreen"
  version="1.2.4"
  name="Test Touchscreen"
  provider-name="Jezz_X, Team XBMC">
  <requires>
    <import addon="xbmc.gui" version="2.11"/>
  </requires>
  <extension
    point="xbmc.gui.skin"
    defaultthemename="textures.xbt"
    debugging="false">
    <res width="1280" height="960" aspect="4:3" default="true" folder="touch4x3" />
  </extension>
  <extension point="xbmc.addon.metadata">
    <summary lang="en">Touchscreen by Jezz_X</summary>
    <description lang="en"></description>
    <platform>all</platform>
  </extension>
</addon> 
and in this case instead of having a 720p it has a touch4x3 folder

Skins I have done....
[Image: skinsq.png]
And others in the past...

Want to know what I'm working on currently? Check me out on Google+
find quote
dazex Offline
Member+
Posts: 548
Joined: Nov 2009
Reputation: 0
Post: #14
Thanks guys. Seems like I didn't merge the codes correctly then. I thought I did.

So, even with a correctly formatted addons.xml, I can't get the iPad to use the correct folder and correct aspect ratio.

Jmarshall, anyway we can have you take another look at your code to make sense of it, and possibly get it merge into the main branch so I can finish polishing up the touch skins?

I don't know which step of the process I a messing up at or if I got all the proper committed code in order for this to work.
find quote
dazex Offline
Member+
Posts: 548
Joined: Nov 2009
Reputation: 0
Post: #15
jezz-x: Any way you can make the xbmc with this option enabled available to me? I would like a build to test against.

Thanks.
find quote
Jezz_X Offline
Team-XBMC Skinner
Posts: 5,264
Joined: Jun 2006
Reputation: 55
Location: Earth
Post: #16
dazex Wrote:jezz-x: Any way you can make the xbmc with this option enabled available to me? I would like a build to test against.

Thanks.

All I have is a win32 version that obviously wont work on anything ios like you should be able to build the original source for linux osx and win32 if you want but the branch code is before the IOS stuff was merged into main

So if you really want I can upload a win32 version but its old code

Skins I have done....
[Image: skinsq.png]
And others in the past...

Want to know what I'm working on currently? Check me out on Google+
find quote
dazex Offline
Member+
Posts: 548
Joined: Nov 2009
Reputation: 0
Post: #17
Jezz_X,
Right, I understood it was for the Win version and prior to the iOS stuff got merge into branch. I just want to have a copy of XBMC to start writing the skin against until we can get the code merge into the main branch.

I tried to merge the code myself but I wasn't successful. I will try again, but until then...a copy of the Win32 version of XBMC with JMarshall's branch code would help tremendously!
find quote
Jezz_X Offline
Team-XBMC Skinner
Posts: 5,264
Joined: Jun 2006
Reputation: 55
Location: Earth
Post: #18
Sure here you go File name: XBMC_arbitrary_skin_resolutions.rar File size: 30.16 MB

but like I said you should be able to compile it for everything but IOS yourself with jmarshalls original code

Skins I have done....
[Image: skinsq.png]
And others in the past...

Want to know what I'm working on currently? Check me out on Google+
find quote
dazex Offline
Member+
Posts: 548
Joined: Nov 2009
Reputation: 0
Post: #19
Thanks Jezz_X. This will help. I didn't want to possibly introduce another variable where things might be mucked up when compiling Jmarshall's branch myself. I just need a working copy so I can work on the 4:3 compatible skin. Hopefully we can get this code merged back into main so I can get a iOS build of XBMC to actually test against. For the time being, this should do nicely.
(This post was last modified: 2011-04-19 04:13 by dazex.)
find quote
dazex Offline
Member+
Posts: 548
Joined: Nov 2009
Reputation: 0
Post: #20
Trying to compile this for iOS again and the compiler errors out at the same point on two different files:

winxml.cpp
winxmldialog.cpp
Code:
The error message is:
error: no matching function for call to 'ADDON::AddonProps::AddonProps(CStdString&, ADDON::TYPE, CStdString&)'

Here is the breakpoint:
Code:
AddonProps props(str, ADDON_SKIN, str);
        CSkinInfo::TranslateResolution(resolution, res);
        CSkinInfo skinInfo(props, res);

This is the commit jmarshall did that I brought into my local master branch as a patch:

https://github.com/jmarshallnz/xbmc/comm...58a#diff-5

Thanks.
find quote