Forced Subtitles in PGS Streams

  Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
Majin Offline
Junior Member
Posts: 12
Joined: Sep 2012
Reputation: 0
Post: #1
Hi there,

The issue is forced subs in bluray rips not showing when subtitles are not turned on. eg Na'vi sections in Avatar

I just commented on hakuya's BRRip playback branch thread (http://forum.xbmc.org/showthread.php?tid=128935) where I explained that by replicating the updates he made in Eden, against the Frodo master, fixes the issue again.

The files updated were:

lib/ffmpeg/libavcodec/avcodec.h
lib/ffmpeg/libavcodec/pgssubdec.c
xbmc/cores/dvdplayer/DVDCodecs/Overlay/DVDOverlayCodecFFmpeg.cpp
lib/ffmpeg/libavcodec/options.c

In commits:
Added support for forced subtitles in PGS streams: https://github.com/hakuya/xbmc/commit/63...acbebf9b55
Pulling in changes from latest pgssubdec.c ffmpeg upstream for PGS decoding fixes: https://github.com/hakuya/xbmc/commit/6f...b2b5694861

Would it be possible to merge these changes with master to resolve a long standing issue?
find quote
da-anda Offline
Team-XBMC Member
Posts: 2,390
Joined: Jun 2009
Reputation: 36
Location: germany
Post: #2
It's unfortunately to late to get this thing in for Frodo. Also the ffmpeg patches are a bit critical atm - might need to wait until we upgrade ffmpeg.
find quote
GreenOnyx Offline
Junior Member
Posts: 39
Joined: Nov 2012
Reputation: 2
Post: #3
This should be fixed with the below commits:

Fixed forced subtitles display in PGS stream: https://github.com/xbmc/xbmc/pull/1992

Don't utilize rect.flags for an external ffmpeg that doesn't support it: https://github.com/xbmc/xbmc/pull/2002


It was discussed under the last couple pages of the older Eden thread: http://forum.xbmc.org/showthread.php?tid...id=1278949
find quote