[PATCH] New passthrough implementation for AAC/MP1/MP2/MP3 support - Testers needed!

**gnif** · 2010-01-20 05:48

Hi all.

I am posting this in the hopes of getting some of you who have receivers that support AAC, MP1, MP2 or MP3 to test this patch set.

http://trac.xbmc.org/ticket/8575

* Adds spdif muxer to ffmpeg
* Modifies CDVDAudioCodecPassthrough to use ffmpeg spdif muxer
* Adds configure switches --enable-lib(dts|a52) to switch back to the old implementation
* Adds downmixing via ffmpeg to CDVDAudioCodecFFmpeg
* Adds AAC passthrough
* Adds MP1 passthrough
* Adds MP2 passthrough
* Adds MP3 passthrough

thetalm · 2010-01-22 01:46

I recently posted a question about xbmc capability for xbmc to passtrough mp3 audio streams over hdmi without conversion in lpcm

my Denon 4308 receiver handles mp3 conversion and has a "restorer" function that improves mp3 audio. I noticed a huge difference in music quality when accessing my music library via dlna against directly from xbmc

so i'available for testing, but i'm a complete linux newby i don't know what i have to do. Have I to download a specific SVN ?

my setup is camelot on ubuntu karmic on a acer revo 3600 connected via hdmi only.

**althekiller** · 2010-01-22 02:32

thetalm Wrote:i noticed a huge difference in music quality when accessing my music library via dlna against directly from xbmc

lol!

**gnif** · 2010-01-29 01:29

The changes are now in svn, just grab the latest revision if you want to test. It would be great if those with MP* and AAC support could provide me feedback on how well it does/doesn't work.

uncertainty · 2010-02-05 01:39

By the way does this mean that realtime AC3 encoding of AAC files is in the works?

thanks

**gnif** · 2010-02-05 07:48

Yes, its on its way Big Grin

**WiSo** · 2010-02-05 19:09

What about the low volume for down mixing is there also something "in the works"? Wink

uncertainty · 2010-02-05 20:13

gnif Wrote:Yes, its on its way

Great to hear.......thanks

dodvan · 2010-02-09 01:20

Reading http://www.xbmc.org/trac/attachment/tick...6/ac3.diff I think I found a small bug, at file xbmc/cores/dvdplayer/DVDCodecs/Audio/DVDAudioCodecPassthroughFFmpeg.cpp, line #56, it should be "memset(m_OutputBuffer, 0, ..." instead of "memset(m_DecodeBuffer, 0, ...".

Is this the proper place to report things like this one? Please excuse me if not (I'm a newbie...) Regards.

The doctor · 2010-02-09 02:07

I use the Denon AVR-1909 with MP3/WMA/AAC restorer. XBMC running via Apple TV and HDMI.

Will add to feedback.

Regards

althekiller Team-XBMC Developer Posts: 4,703 Joined: May 2004 Reputation: 12	2010-01-22 02:32 Post: #3 thetalm Wrote:i noticed a huge difference in music quality when accessing my music library via dlna against directly from xbmc lol! Howto post your problem in a useful manner. #xbmc-linux on FreeNode XBMC online-manual, FAQ, search, forum rules, how to submit a bugreport.
	find quote

gnif Team-XBMC Developer Posts: 442 Joined: Feb 2008 Reputation: 34 Location: Australia, Katoomba	2010-01-29 01:29 Post: #4 The changes are now in svn, just grab the latest revision if you want to test. It would be great if those with MP* and AAC support could provide me feedback on how well it does/doesn't work. I am not scared of SVN - Cutting my hands open on the bleeding edge.
	find quote

uncertainty Fan Posts: 521 Joined: Jun 2009 Reputation: 0 Location: Jersey	2010-02-05 01:39 Post: #5 By the way does this mean that realtime AC3 encoding of AAC files is in the works? thanks
	find quote

gnif Team-XBMC Developer Posts: 442 Joined: Feb 2008 Reputation: 34 Location: Australia, Katoomba	2010-02-05 07:48 Post: #6 Yes, its on its way I am not scared of SVN - Cutting my hands open on the bleeding edge.
	find quote

WiSo Team-XBMC Developer Posts: 2,483 Joined: Oct 2003 Reputation: 0 Location: Germany	2010-02-05 19:09 Post: #7 What about the low volume for down mixing is there also something "in the works"? Always read the XBMC online-manual, FAQ and search the forum before posting. Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules. For troubleshooting and bug reporting please make sure you read this first.
	find quote

uncertainty Fan Posts: 521 Joined: Jun 2009 Reputation: 0 Location: Jersey	2010-02-05 20:13 Post: #8 gnif Wrote:Yes, its on its way Great to hear.......thanks
	find quote

The doctor Junior Member Posts: 28 Joined: Jan 2010 Reputation: 0	2010-02-09 02:07 Post: #10 I use the Denon AVR-1909 with MP3/WMA/AAC restorer. XBMC running via Apple TV and HDMI. Will add to feedback. Regards
	find quote